Repository navigation
feat(insight-kit): agents-system-v2 — Phase 1-6 restructure + T17 harness + B1 eval/omp extraction - #17
Merged
Conversation
…nsights
B1 of the eval-harness extraction. Two pure modules and their tests move
into insight-kit so any analyst/critic loop can reuse them without copying
files. growth_insights becomes the reference consumer.
## New modules
- `platform/eval/score.py` — 9-check structural + semantic score gate.
Pure logic, no nairomarket coupling. CLI: `python -m insight_kit.platform.eval.score <run_dir>`
- `integrations/omp/session_parser.py` — omp 15.2.4 session JSONL parser.
Reverse-engineers the hidden `.tmp` dotfile layout into typed ParsedTurn /
ParsedToolCall. Includes the persona-boundary regex
(`run_analyst_critic.py.*--critic-phase`).
Both expose clean public surfaces via `__init__.py` re-exports.
## Tests
Mirrored from growth_insights, adapted to native package imports (no importlib
shim). 37 new tests, all passing alongside the existing suite (583 total).
- `tests/platform/eval/test_score.py` — 20 tests covering regex variants,
citation cross-check (multi-source, .py extractors, empty paths, bare
tokens), length prior boundaries, integration scenarios.
- `tests/integrations/omp/test_session_parser.py` — 17 tests covering
parsing, persona boundary, edge cases (empty/missing/truncated/no-usage),
tool calls, find_session_file selection.
- `tests/integrations/omp/fixtures/omp_session_sample.jsonl` — anonymised
real omp v15.2.4 session line.
## Version
0.1.0a3 → 0.1.4 (drop alpha, normalize patch).
## Next (B1 cont. on growth_insights side)
Replace growth_insights/deploy/eval/{score,omp_session_parser}.py with
thin re-export shims pointing at the new insight-kit modules. Add
insight-kit as a Python dep in growth_insights pyproject.toml (editable
path install). Verify growth_insights tests still pass via the shims.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles 60 commits of agents-system-v2 feature work into main. Three major threads:
1. Monorepo restructure (Phases 1-6)
Scaffolds the
platform/libs/integrations/surfaces/deploy/group layout (Phase 1), then moves each module group into its canonical location (Phases 2-5), and drops all shims (Phase 6).2. T-series gate + harness work
3. B1 — eval-harness extraction from growth_insights (last commit, cdbec4b)
Extracts the runtime-side score gate + omp session parser out of growth_insights and into insight-kit so they're reusable across consumer repos.
platform/eval/score.py— 9-check structural + semantic score gateintegrations/omp/session_parser.py— omp 15.2.4 session JSONL parserVersion bump:
0.1.0a3→0.1.4.Test plan
pytest— 583/583 passpytest tests/test_score.py tests/test_session_parser.py38/38Companion