Skip to content

fix(vm_service): don't warn about a lost connection when the app quits - #567

Merged
sidlatau merged 1 commit into
mainfrom
fix/vm-service-quit-warning
Nov 20, 2026
Merged

sidlatau merged 1 commit into
mainfrom
fix/vm-service-quit-warning

Conversation

@sidlatau

Copy link
Copy Markdown
Collaborator
  • DebuggerRunner:send("quit") and cleanup() disconnect from the VM service before the session ends: the adapter sends terminated only after the VM service has gone away, so the drop looked like a lost connection.
  • The client warns only once the first reconnect attempt has failed, and says it reconnected only after such a warning. This covers sessions ended from nvim-dap directly.

Merge danger: two-way door, blast radius: VM service connection notifications and the quit path of the DAP runner.

@sidlatau
sidlatau merged commit 2d7b894 into main Nov 20, 2026
6 of 7 checks passed
@sidlatau
sidlatau deleted the fix/vm-service-quit-warning branch November 20, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant