Repository navigation
perf: defer non-critical client plugin work until after hydration - #490
Merged
Merged
Conversation
✅ Deploy Preview for nuxt-color-mode canceled.
|
commit: |
atinux
reviewed
Oct 27, 2026
atinux
approved these changes
Oct 27, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
this trims work from the client plugin before hydration.
we now wait until the app has hydrated and the browser is idle before setting preference.
it's almost always the value that was just read from it (and with
storage: 'cookie'this also invokesuseCookie, sets up watchers, etc.). this also fixes a small issue in SSR mode with local or session storage, where the default preference used to overwrite the stored value beforeapp:mountedthen wrote it back againthe
prefers-color-schemelistener is now deferred, rather than running before hydration.the plugin now reuses the inline script's value until hydration.
with
preference: 'system', the inline script resolves the color scheme , but previously we re-resolved it - meaning potentially up to six extramatchMediacalls.