Repository navigation
Disable the fallback access point and captive portal - #94
Merged
Merged
Conversation
Drop the wifi ap and captive_portal from the shared wifi package. The AP only starts when a device can't join the configured network, and the recovery path for changed credentials is a temporary SSID with the old credentials plus an OTA, so the fallback isn't needed. Remove the per-device pwd substitution that only fed the AP password. Also move the emporia-vue2 play_rtttl API service to the actions: syntax. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Drop the external_components pin on the esphome/esphome pzem6l24 commit. It only existed because the automation.register_apply_action change landed after the 2026.9 branch cut; 2026.10.0 carries it, so the component resolves from ESPHome itself. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
pzem6l24 is part of ESPHome core as of 2026.10.0 and pool.yaml no longer pins or overrides it, so the local copy is dead code. Drop it along with its README and CI/doc references. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Build without a precompiled header in the compile jobs. 2026.10 enables PCH by default, and clang-tidy replays the build's flags but can't read GCC's PCH (or find esphome_pch.h on ESP8266). - second-garage-door: also remove the ratgdo web_server OTA entry that ratgdo main now adds, since we remove web_server itself. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared wifi package enabled a fallback AP and captive portal on every device as insurance against bricking a device whose wifi credentials changed. With UniFi, the recovery for changed credentials is simpler: create a temporary SSID with the old credentials and OTA the device. The AP only ever starts when a device can't join its configured network, so it isn't needed.
Also folds in the small changes needed for ESPHome 2026.10.0: pool now uses the core pzem6l24, so the git pin and the local copy of the component go away.
Changes:
ap:andcaptive_portal:fromdevices/packages/wifi/wifi.yaml.pwdsubstitution (it only fed the AP password) from the device configs.play_rtttlAPI service to theactions:syntax.external_componentspin on the esphome/esphome pzem6l24 commit frompool.yaml(2026.10.0 carries theregister_apply_actionchange it was waiting on).components/pzem6l24and its README, CI comment and doc links.Behavior on upgrade: a device that can't reach its wifi network no longer opens a recovery AP. It still reboots on the default
reboot_timeoutand can be recovered with a temporary SSID plus OTA, or a serial flash.Not verified: no
esphome configor compile was run locally; CI covers validation and compiles. Unused*_pwdentries remain in the gitignoreddevices/secrets.yaml.🤖 Generated with Claude Code