Repository navigation
Add a repo-local pr-workflow skill; correct two stale command docs - #89
Merged
Merged
Conversation
The `pr-workflow` skill that surfaces in this working directory belongs to the sibling dev_esphome/ checkout and describes contributing to upstream ESPHome core -- base on upstream/dev, fill in their PR template, prefix the title with [component], target esphome/esphome. Invoking it here produces the wrong workflow every time. commit_pr.md warned about this in prose, but nothing owned the name for this repo, so the name still resolved upstream. Add .claude/skills/pr-workflow/SKILL.md covering this repo's conventions: branch prefixes, base master, title and body style, the seven required checks and how long they take, and the squash-merge details. It defers the commit steps to /commit and the full cycle to /commit_pr rather than restating them. Also fixes two things in the existing command docs that were no longer true: - commit_pr.md said master has no required status checks and that a merge should go through immediately. Master now requires all seven CI checks with enforce_admins on, so a merge waits on CI. - commit.md said to run `python -m pre_commit` because the pre-commit CLI is not on PATH. The reverse is now true: pre-commit is installed via pipx and shimmed at ~/.local/bin/pre-commit, and the python on PATH has no pre_commit module, so the documented command fails outright. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pr-workflowskill that surfaces in this working directory belongs to the siblingdev_esphome/checkout and describes contributing to upstream ESPHome core — base onupstream/dev, fill in their PR template, prefix the title with[component], targetesphome/esphome. Invoking it here produces the wrong workflow every time.commit_pr.mdwarned about this in prose, but nothing owned the name for this repo, so the name still resolved upstream.Changes:
.claude/skills/pr-workflow/SKILL.mdcovering this repo's conventions: branch prefixes (f/,b/,chore/), basemaster, title and body style, the seven required checks and how long they take, and the squash-merge details. It defers the commit steps to/commitand the full cycle to/commit_prrather than restating them.commit_pr.md, which said master has no required status checks and that a merge should go through immediately. Master now requires all seven CI checks withenforce_adminson, so a merge waits on CI. Its blanket "don't use thepr-workflowskill" warning is now scoped to the upstream one, with a concrete tell for distinguishing them.commit.md, which said to runpython -m pre_commitbecause the pre-commit CLI is not onPATH. The reverse is now true — pre-commit is installed via pipx and shimmed at~/.local/bin/pre-commit, and thepythononPATHhas nopre_commitmodule, so the documented command fails outright. Verified in both bash and PowerShell.Verified with
pre-commit run --all-files(all hooks pass). Docs and skill files only; no device configs or component code touched.🤖 Generated with Claude Code