Skip to content

💚 fix failing docs deploy CI job after Zizmor fixes#871

Merged
jorenham merged 1 commit intonumpy:mainfrom
Aniketsy:fix-870
May 7, 2026
Merged

💚 fix failing docs deploy CI job after Zizmor fixes#871
jorenham merged 1 commit intonumpy:mainfrom
Aniketsy:fix-870

Conversation

@Aniketsy
Copy link
Copy Markdown
Contributor

@Aniketsy Aniketsy commented May 7, 2026

#870
as persist-credentials: false was blocking so setting up the remote url with the token . should fix

I also looked the approach you followed in optype, but i think for that we need to do more changes.
please let me know if we should follow different way.

@jorenham jorenham changed the title fix-docs deploy CI job is failing after Zizmor fixes 💚 fix failing docs deploy CI job after Zizmor fixes May 7, 2026
@jorenham jorenham requested a review from Copilot May 7, 2026 09:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the docs deployment GitHub Actions workflow failing after setting persist-credentials: false by explicitly configuring the origin remote to use the workflow’s GITHUB_TOKEN, allowing mkdocs gh-deploy to push.

Changes:

  • Update the docs deploy workflow to set origin to an authenticated HTTPS URL using GITHUB_TOKEN.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jorenham jorenham enabled auto-merge (squash) May 7, 2026 09:50
@jorenham jorenham merged commit a18562f into numpy:main May 7, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants