Skip to content

feat(collector): ignore priv/static by default #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aspala merged 1 commit into from
Sep 1, 2026
Merged

feat(collector): ignore priv/static by default #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/codeqa/engine/collector.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ defmodule CodeQA.Engine.Collector do
.next coverage
])

@default_ignore_patterns ~w[**/*.md **/*.mdx]
# priv/static holds build output, so its bundles skew line-length and duplication metrics.
@default_ignore_patterns ~w[**/*.md **/*.mdx priv/static/** **/priv/static/**]

@spec source_extensions() :: MapSet.t()
def source_extensions,
Expand Down
13 changes: 13 additions & 0 deletions test/codeqa/collector_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,19 @@ defmodule CodeQA.CollectorTest do
refute Map.has_key?(files, "test/app_test.exs")
end

test "excludes built assets under priv/static by default", %{tmp_dir: tmp_dir} do
File.mkdir_p!(Path.join(tmp_dir, "priv/static/assets"))
File.mkdir_p!(Path.join(tmp_dir, "apps/web/priv/static/assets"))
File.write!(Path.join(tmp_dir, "priv/static/assets/app.js"), "var a=1")
File.write!(Path.join(tmp_dir, "apps/web/priv/static/assets/app.js"), "var a=1")

files = Collector.collect_files(tmp_dir)

assert Map.has_key?(files, "lib/app.ex")
refute Map.has_key?(files, "priv/static/assets/app.js")
refute Map.has_key?(files, "apps/web/priv/static/assets/app.js")
end

test "respects ignore_paths from .codeqa.yml", %{tmp_dir: tmp_dir} do
File.mkdir_p!(Path.join(tmp_dir, "generated"))
File.write!(Path.join(tmp_dir, "generated/schema.ex"), "defmodule Schema do\nend")
Expand Down
Loading