Skip to content

change python3 to sys.executable in tests - #81

Merged
jwaiton merged 2 commits into
nu-ZOO:mainfrom
Ian0sborne:fix-macos-tmux-compatibility
Apr 29, 2026
Merged

jwaiton merged 2 commits into
nu-ZOO:mainfrom
Ian0sborne:fix-macos-tmux-compatibility

Conversation

@Ian0sborne

Copy link
Copy Markdown
Contributor

This PR addresses #78 where it was found that on a MacOS device, when using tmux, the system defaults to a specific python version that is different from the one set by MULE.

By using sys.executable we make the code use the exact Python binary running the test, removing dependencies on tmux, shell configs etc.

@Ian0sborne
Ian0sborne requested review from a team, MattZur and jwaiton April 28, 2026 15:43

@MattZur MattZur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Mac OS X.

Approved.

Comment thread packs/tests/setup_test.py Outdated
# this should be more complex in the future, such as if the config (which
# will be a default for the tests) returns the test flag return a number, or
# something in particular from subprocess
# something in particuelar from subprocess

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a funny spelling mistake, other than this, looks good! Will approve upon fixing

@jwaiton jwaiton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR resolves a continuous issue in MULE, allowing for tests to be run on MacOS once again!

#56 should now be implemented to ensure that non-functionality with MacOS systems is noticed before PRs are merged.

Good work!

@jwaiton
jwaiton merged commit 1588656 into nu-ZOO:main Apr 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants