Fix native-extension CI checks and switch linting to Ruff#201
Open
CoolJosh0221 wants to merge 2 commits into
Open
Fix native-extension CI checks and switch linting to Ruff#201CoolJosh0221 wants to merge 2 commits into
CoolJosh0221 wants to merge 2 commits into
Conversation
Collaborator
|
#198 needs to be committed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the native-extension checks in
tests.ymltrustworthy: the install no longer pipes throughtee(which masked pip failures under the default shell), and the jobs verify the build by importing the compiled modules directly instead of grepping build logs for meson message strings. The no-BLAS job now only accepts the two expected modules as missing (ModuleNotFoundErrorwith a matching name) rather than swallowing anyImportError.Also replaces the errors-only pylint job with Ruff (pinned to 0.15.21) scoped to correctness rules (
E9,F,LOG,RUF100), grandfathering pre-existing unused imports/locals inlibact/andexamples/, and cleans up a duplicate/unused import indocs/conf.py.ruff checkpasses on this branch. The lint workflow/job names changed, so any branch-protection required checks referencing the old names need updating.