Repository navigation
fix(web): mixed settings switches can reverse partial saves - #22
Draft
not-compromised wants to merge 2 commits into
Draft
not-compromised wants to merge 2 commits into
not-compromised wants to merge 2 commits into
Conversation
not-compromised
added a commit
to not-compromised/pr-media-public
that referenced
this pull request
Oct 31, 2026
not-compromised
added a commit
to not-compromised/pr-media-public
that referenced
this pull request
Oct 31, 2026
not-compromised
added a commit
to not-compromised/pr-media-public
that referenced
this pull request
Oct 31, 2026
not-compromised
added a commit
to not-compromised/pr-media-public
that referenced
this pull request
Oct 31, 2026
not-compromised
added a commit
to not-compromised/pr-media-public
that referenced
this pull request
Oct 31, 2026
not-compromised
added a commit
to not-compromised/pr-media-public
that referenced
this pull request
Oct 31, 2026
not-compromised
added a commit
to not-compromised/pr-media-public
that referenced
this pull request
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an older server drops a setting, the switch stays mixed and every subsequent click requests
true, preventing reversal. Linked environments failed on pmserver but saved on pdtop and pltop.The switch now remembers the last requested value, so the next click can reverse a partial enable or disable. Uniform selections display server state. This changes the shared desktop and web control within the fork's boundaries.
Regression tests fail before the fix and pass afterward for both directions and representative environments. Focused tests, targeted lint, and the web typecheck pass.
Browser verification reproduced repeated
truerequests before the fix and successful reversal afterward at desktop and narrow widths. The isolated two-server fixture drops one setting through a proxy. It uses Auto-resume limited threads because this base predates Linked environments, exercising the same control and persistence path.Gitleaks found no leaks. The fleet security scan worker failed. Outside review is missing.
Original report:
Isolated reproduction before and after:
CI batch: linked-env-94dfad88
Sol 6.1 via T3 Code, Codex harness.