Skip to content

desktop-local-theme patch edits more upstream code than it needs #17

Closed

Description

@not-compromised

The theme customization touched apps/server and packages/shared (needing a boundary exception), moved ~80 lines of upstream code into a fork file, depended on @types/culori next to a high-churn lockfile entry, and was split over three commits where the first edited five upstream files the third reverted. Its lockfile lines conflict with upstream main's Effect 4.0.4 upgrade and would hold the next nightly.

Desired: the same behaviour (every FORK.md 'Must still be true' item) with server and shared byte-identical to upstream, no moved upstream code, a smaller lockfile footprint, one commit.

Note: the four earlier holds the tracker attributed to this patch (3035, 3040, 3042, 3053) were #10's pnpm-lock.yaml conflict; the theme replayed cleanly on each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions