Repository navigation
Description
Summary
On the shipped Flux fixture, the checker tells the builder to write level 30.MODEL 17.model move 30. Applying that exact line makes the scheduler wire horizontal but breaks the already horizontal UNETLoader → ModelSamplingFlux wire and moves ModelSamplingFlux out of the documented model row. With the shared width/height nodes present, it also replaces the original rule violation with a model-chain column violation. This concerns layout advice; no image-generation failure was tested or observed.
Steps to reproduce
From a checkout of either tested build, save the following as repro.py, then run python3 repro.py . /tmp/readable-node-repro with a work path that does not already exist. The script uses only the repository's tests/fixtures/flux_t2i.json and saved object_info.json; it starts no ComfyUI server and needs no models. It builds a 16-node workflow using relational commands, applies the original plan, then appends the exact checker suggestion. All steps below were executed.
import json, os, subprocess, sys
from pathlib import Path
root = Path(sys.argv[1]).resolve()
work = Path(sys.argv[2]).resolve()
work.mkdir()
canvas = root / 'skills/comfyui-readable-node/scripts/canvas.py'
def run(*args):
result = subprocess.run([sys.executable, str(canvas), '--dir', str(work), *args], cwd=work, text=True, capture_output=True, env={**os.environ, 'PYTHONDONTWRITEBYTECODE': '1'})
print(result.stdout, end='')
print(result.stderr, end='')
result.check_returncode()
run('open', str(root / 'tests/fixtures/flux_t2i.json'), str(root / 'tests/fixtures/object_info.json'))
run('new', 'flux')
(work / 'build.txt').write_text('''copy 12 11 10 30 6 26 22 25 16 17 27 34 35 13 8 9
link 12.MODEL 30.model 11.CLIP 6.clip 6.CONDITIONING 26.conditioning 26.CONDITIONING 22.conditioning
link 30.MODEL 22.model 30.MODEL 17.model 25.NOISE 13.noise 22.GUIDER 13.guider 16.SAMPLER 13.sampler 17.SIGMAS 13.sigmas
link 34.INT 30.width 34.INT 27.width 35.INT 30.height 35.INT 27.height 27.LATENT 13.latent_image
link 13.output 8.samples 10.VAE 8.vae 8.IMAGE 9.images
title 34 "Int: width"
title 35 "Int: height"
''')
plan = '''put 13 origin
inputs 13
block inputsources 25 22 16 17 27
put 26 left inputsources wire
put 6 left 26 wire
block model 12 30
row 12 30 gap wide
put model above 26 right
put 10 above 13
put 8 right 13 wire
put 9 right 8 wire
put 11 left 6 wire
block conditioning 11 6 26
block sampling 25 22 16 17 27 13
block output 8 9
block dimensions 34 35
row 34 35
put dimensions left 30 below 6 gap wide
level 34.INT 27.width move 34
level 35.INT 27.height move 35
'''
(work / 'layout.txt').write_text(plan)
run('run', 'build.txt')
for label, extra in [('before', ''), ('after', 'level 30.MODEL 17.model move 30\n')]:
(work / 'layout.txt').write_text(plan + extra)
print(label)
run('layout', 'layout.txt')
run('check')
state = json.loads((work / 'canvas/flux.json').read_text())
print('node positions:', {n['id']: n['pos'] for n in state['nodes'] if n['id'] in {'12', '30', '17', '26'}})
(work / (label + '.json')).write_text(json.dumps(state, indent=2))Expected behavior
Advice presented as making a slanted wire horizontal without slanting another wire should preserve existing horizontal chain wires when applied through the documented layout entry point. For this Flux form, advice should also respect the separate model and sigma rows, or explain the applicable rule exception rather than directing the builder to a conflicting form. This does not require one particular repair or assert that every possible relational layout fails.
Actual behavior
Both tested builds give identical output. Before the suggestion, the layout has zero overlaps, zero unplaced nodes, no missing required inputs, and one rule violation:
[readable-form.md 3. Wires] slanted wire that one move makes horizontal: 30.MODEL → 17.model (write level 30.MODEL 17.model move 30)
After applying that line, the original violation disappears, but a new one appears:
[readable-form.md 4. Flow and position] model chain end 30 ModelSamplingFlux: its right edge (-390) is not the right edge of the column left of 22 BasicGuider (-780, 35 PrimitiveInt)
The checker also newly reports:
non-horizontal wire (MODEL, input below the output): 12.MODEL → 30.model
Node 12 stays at [-1080, -354]; node 30 moves from [-660, -354] to [-660, 175], level with BasicScheduler rather than in the row above FluxGuidance. The original layout already has ten ancillary notices, so this is not a claim that it has an entirely clean check. Removing the shared dimension nodes and their plan lines still reproduces the faulty suggestion and newly slanted loader wire, but not the model-column violation. Changing the suggestion to move the whole model block preserves the loader wire, but still moves the model row below the conditioning row and retains the column violation in the full case.
Evidence
- Expected source:
skills/comfyui-readable-node/references/readable-form.md, §3 defines the one-move Bad form as becoming horizontal without slanting another wire;references/examples.md, Layout §1, places Flux's model chain on row 1 and the conditioning on row 2, and says not to put model loading and sigma computation on one row merely because they connect.scripts/canvas.pycommand help sayslevel ... move <unit>moves the named unit, and the node/block distinction says naming a node inside a block moves only that node. - Failure source: Executed script above, both
layout/checkoutputs and savedbefore.json/after.jsonnode positions;scripts/canvas.py:1748–1808containsone_move_levelsand_chk_one_move_level, andmove_closurepreserves horizontal connected nodes when evaluating a candidate move, while the emitted line names only its starting node. - Evidence provenance: observed
- Local verification: reproduced
- Reproduction completeness: complete
Runtime or environment
- Latest published release tested: v0.1.0, commit
ca74cbddc298741cac975baf951f92485b50f797. - Current default branch tested: main, commit
10eee4347cfebf9608dd2e4b1216a7e4ee5db9d0. Its completeskillstree is identical to the release's; both were executed separately. - Linux x86_64, Python 3.14.8. No running ComfyUI or frontend is used by this reproduction.
- Agent and model: Codex, gpt-6.1-sol.
Restoration check
Run the same fixture and plan through layout and check. Any proposed horizontal-wire move should be executable as printed, preserve existing horizontal model-chain wires and the applicable model/sigma row constraints, and avoid introducing a conflicting model-column rule violation. If no such move fits this form, the checker should not present this move as mandatory. Preserve checks for genuinely fixable slanted wires; do not simply disable the check. Reapplying the original plan restores the prior loader alignment and model row, but leaves the disputed suggestion.
References
PR #12 previously changed the one-move check to exclude moves that take a sampler source column along. This case concerns its model-chain advice and still reproduces in the published build; it does not request a reply on the merged PR.
Triage assessment
- Impact level: P2
- Assessment status: supported
- Impact basis: Following specific checker guidance worsens a documented core Flux layout and trades one required layout correction for another; the effect is confined to layout and checker guidance in this reproduced case, with no demonstrated generation failure or data loss.
- Workaround status: available
- Workaround basis: Reapplying the original relational plan restores the prior model row and horizontal loader wire; the builder can retain that arrangement and disregard this specific suggestion while the checker notice remains.
Activity