Skip to content

test: re-enable HTTP/2 churn test on Node.js 26 - #5961

Open
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:re-enable-h2-churn-test-node26
Open

mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:re-enable-h2-churn-test-node26

Conversation

@mcollina

@mcollina mcollina commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

Re-enable the HTTP/2 connection-churn stress test (test/http2-request-never-settles.js) on Node.js 26, while keeping it skipped on Node.js 22 (and the pre-existing Node.js 24/25 Maglev skip).

Motivation

The test was skipped on Node.js 26 (#5742) because node:http2 aborted on an internal onread->IsFunction() assertion during session teardown — nodejs/node#64850.

The same assertion still affects the latest Node.js 22.x, whose fix has not been backported yet.

Verification

Change

  • Node.js 26: skip only pre-fix builds (nodeMajor === 26 && nodeMinor < 10); current/future 26.x (≥ 26.10.0) runs the test.
  • Node.js 22: keep skipping entirely until the v22.x backport (nodejs/node#66515, still open) is released.
- const skipForOnreadAssertion = nodeMajor === 26
+ // nodejs/node#64850 was fixed by nodejs/node#65116, first shipped in v26.10.0.
+ // The v22.x backport (nodejs/node#66515) has not been released yet.
+ const skipForOnreadAssertion =
+   nodeMajor === 22 ||
+   (nodeMajor === 26 && nodeMinor < 10)

The unrelated Node.js 24/25 Maglev SIGSEGV skip (nodejs/node#64841, still open) is preserved.

…e.js 22

nodejs/node#64850 (onread->IsFunction() assertion during session
teardown) was fixed by nodejs/node#65116, which first shipped in
Node.js v26.10.0. Restrict the Node.js 26 skip to versions before the
fix so the test runs again on current 26.x and later.

The v22.x backport (nodejs/node#66515) has not been released yet, so
keep the test skipped on Node.js 22 until a release carries the fix.
@mcollina
mcollina force-pushed the re-enable-h2-churn-test-node26 branch from 8226bd3 to dd6cd49 Compare October 5, 2026 13:33
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.13%. Comparing base (eedbe2d) to head (dd6cd49).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5961      +/-   ##
==========================================
+ Coverage   86.11%   86.13%   +0.01%     
==========================================
  Files         115      115              
  Lines       45723    45727       +4     
==========================================
+ Hits        39376    39386      +10     
+ Misses       6347     6341       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

http2: assertion failure onread->IsFunction() when a session is destroyed from a 'stream' handler

2 participants