Repository navigation
Conversation
…e.js 22 nodejs/node#64850 (onread->IsFunction() assertion during session teardown) was fixed by nodejs/node#65116, which first shipped in Node.js v26.10.0. Restrict the Node.js 26 skip to versions before the fix so the test runs again on current 26.x and later. The v22.x backport (nodejs/node#66515) has not been released yet, so keep the test skipped on Node.js 22 until a release carries the fix.
mcollina
force-pushed
the
re-enable-h2-churn-test-node26
branch
from
October 5, 2026 13:33
8226bd3 to
dd6cd49
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5961 +/- ##
==========================================
+ Coverage 86.11% 86.13% +0.01%
==========================================
Files 115 115
Lines 45723 45727 +4
==========================================
+ Hits 39376 39386 +10
+ Misses 6347 6341 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enable the HTTP/2 connection-churn stress test (
test/http2-request-never-settles.js) on Node.js 26, while keeping it skipped on Node.js 22 (and the pre-existing Node.js 24/25 Maglev skip).Motivation
The test was skipped on Node.js 26 (#5742) because
node:http2aborted on an internalonread->IsFunction()assertion during session teardown — nodejs/node#64850.The same assertion still affects the latest Node.js 22.x, whose fix has not been backported yet.
Verification
205443721d) fixes http2: assertion failureonread->IsFunction()when a session is destroyed from a 'stream' handler node#64850.tests 2, pass 2, fail 0, skipped 0).skipped 2), avoiding theonread->IsFunction()abort that currently crashes CI.Change
nodeMajor === 26 && nodeMinor < 10); current/future 26.x (≥ 26.10.0) runs the test.The unrelated Node.js 24/25 Maglev SIGSEGV skip (nodejs/node#64841, still open) is preserved.