fix(client-h2): avoid double-decrement of open streams on timeout#5071
Draft
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Draft
fix(client-h2): avoid double-decrement of open streams on timeout#5071deepview-autofix wants to merge 1 commit intonodejs:mainfrom
deepview-autofix wants to merge 1 commit intonodejs:mainfrom
Conversation
The 'timeout' handler was manually decrementing session[kOpenStreams] before calling abort(). abort() closes the stream, which triggers the 'close' handler that also decrements the counter, causing the counter to go negative and leading to session.unref() being called while streams are still active. Let the 'close' handler own the decrement, matching the pattern used by the other stream lifecycle events. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5071 +/- ##
==========================================
- Coverage 93.09% 93.09% -0.01%
==========================================
Files 110 110
Lines 35788 35782 -6
==========================================
- Hits 33318 33312 -6
Misses 2470 2470 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
why is this a draft? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'timeout' handler was manually decrementing session[kOpenStreams] before calling abort(). abort() closes the stream, which triggers the 'close' handler that also decrements the counter, causing the counter to go negative and leading to session.unref() being called while streams are still active.
Let the 'close' handler own the decrement, matching the pattern used by the other stream lifecycle events.