fix(http2): allow GET and HEAD request bodies over h2#5058
Open
trivikr wants to merge 1 commit intonodejs:mainfrom
Open
fix(http2): allow GET and HEAD request bodies over h2#5058trivikr wants to merge 1 commit intonodejs:mainfrom
trivikr wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5058 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 110 110
Lines 35807 35807
=======================================
Hits 33339 33339
Misses 2468 2468 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Assisted-by: OpenAI:gpt-5.4 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Member
|
Cana you verify if those are allowed in http1? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes: #5057
Rationale
HTTP/2 requests with a body on
GETandHEADcurrently fail withERR_STREAM_WRITE_AFTER_END.Changes
endStreamdecision to depend on whether the normalized request body isnull, instead of special-casingGETandHEAD.test/http2-body.jscovering HTTP/2GETandHEADrequests with bodies.Features
N/A
Bug Fixes
Fix
ERR_STREAM_WRITE_AFTER_ENDfor HTTP/2GETandHEADrequests with a bodyBreaking Changes and Deprecations
N/A
Status