Skip to content

child_process: propagate config-file permission flags to children - #66559

Open
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:child-process-propagate-config-file-permission-fla
Open

child_process: propagate config-file permission flags to children#66559
RafaelGSS wants to merge 2 commits into
nodejs:mainfrom
RafaelGSS:child-process-propagate-config-file-permission-fla

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 6, 2026

Copy link
Copy Markdown
Member

child_process: propagate config-file permission flags to children

@RafaelGSS
child_process: propagate config-file permission flags to children
e1bc180 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Oct 6, 2026
@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model. label Oct 6, 2026
@RafaelGSS RafaelGSS added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Oct 6, 2026
@codecov

codecov Bot commented Oct 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.40%. Comparing base (fcfb7ec) to head (d123050).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/child_process.js 9.09% 20 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #66559      +/-   ##
==========================================
- Coverage   90.40%   90.40%   -0.01%     
==========================================
  Files         791      791              
  Lines      276226   276404     +178     
  Branches    53045    53070      +25     
==========================================
+ Hits       249732   249881     +149     
- Misses      16899    16923      +24     
- Partials     9595     9600       +5
Files with missing lines Coverage Δ
lib/child_process.js 91.39% <9.09%> (-1.61%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 6, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 6, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78219/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. child_process Issues and PRs related to the child_process subsystem. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RafaelGSS @nodejs-github-bot @marco-ippolito