Conversation
Without it, --allow-fs-vfs was accepted without --permission and was not propagated to child processes like the other --allow-* flags. Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
RafaelGSS
marked this pull request as ready for review
October 6, 2026 09:38
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66554 +/- ##
=======================================
Coverage 90.40% 90.41%
=======================================
Files 791 791
Lines 276226 276227 +1
Branches 53045 53036 -9
=======================================
+ Hits 249732 249742 +10
Misses 16899 16899
+ Partials 9595 9586 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL @mcollina
This is a "breaking change", but it's a bug fix and considering --allow-fs-vfs is experimental, I wouldn't consider it as
semver-major.