Conversation
Signed-off-by: lazerg <lazerg2@gmail.com> Assisted-by: Claude Code
Collaborator
|
Review requested:
|
Contributor
|
Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66552 +/- ##
=======================================
Coverage 90.40% 90.41%
=======================================
Files 791 791
Lines 276226 276233 +7
Branches 53045 53046 +1
=======================================
+ Hits 249732 249761 +29
+ Misses 16899 16864 -35
- Partials 9595 9608 +13
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client response has
setEncoding()set, thedatalistener that network inspection adds gets strings instead of Buffers.chunk.byteLengthis then undefined, soNetwork.dataReceivedthrows "Missing dataLength in event" and the request fails. This turns string chunks back into a Buffer using the stream's encoding before reporting them. The http2 client had the same listener and the same problem, so it gets the same fix.Fixes: #66551