Skip to content

test_runner: report load errors with --test-isolation=none - #66550

Open
lazerg wants to merge 1 commit into
nodejs:mainfrom
lazerg:fix/issue-66549-isolation-none-load-error
Open

lazerg wants to merge 1 commit into
nodejs:mainfrom
lazerg:fix/issue-66549-isolation-none-load-error

Conversation

@lazerg

@lazerg lazerg commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

With --test-isolation=none, a test file that throws while loading after it has already registered a test was reported as passing. The import error was caught but only reported through the placeholder test, which was added only when the file registered no tests, so the error was dropped and the run exited 0.

This adds the placeholder test whenever the import throws, so the error is shown and the run fails like it does with process isolation.

Fixes: #66549

Signed-off-by: lazerg <lazerg2@gmail.com>
Assisted-by: Claude
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Caution

AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context.

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.40%. Comparing base (9a85290) to head (b15873e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66550      +/-   ##
==========================================
- Coverage   90.40%   90.40%   -0.01%     
==========================================
  Files         791      791              
  Lines      276120   276120              
  Branches    53032    53019      -13     
==========================================
- Hits       249634   249630       -4     
+ Misses      16896    16895       -1     
- Partials     9590     9595       +5     
Files with missing lines Coverage Δ
lib/internal/test_runner/runner.js 95.13% <100.00%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 6, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@atlowChemi atlowChemi added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentscan:community-flagged author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_runner: with --test-isolation=none, a file that throws after registering a test passes (exit 0, error not shown)

6 participants