Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
|
Review requested:
|
Member
|
I don't think anything in the Jenkins CI is on clang 21, other than maybe We generally avoid compiling our own version of e.g. clang or install a version on a Linux distro outside of the distro's package manager because it does not replicate what we'd be expecting contributors/downstream builders to be doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simdjson 5.0.0 (bot PR is #66495) has introduced use of exceptions (on methods we don't use), and clang 19 refuses to compile it with
-fno-exceptions(which we pass). clang 21 accepts to compile as long as thethrowstatements can be tree-shaken away, so bumping our requirement on Node.js 27+ might be preferable than floating a patch on simdjson./cc @nodejs/build