Skip to content

lib: set exit code on failed node:bench run() - #66534

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:set-exit-code-on-failed-node-bench-run
Open

RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:set-exit-code-on-failed-node-bench-run

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

I noticed the run() was exiting with exitCode 0 even when the benchmark fn fails

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSS requested a review from jasnell October 5, 2026 14:38
@RafaelGSS
RafaelGSS marked this pull request as ready for review October 5, 2026 14:38
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 5, 2026
@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (773bdd1) to head (6401472).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66534      +/-   ##
==========================================
- Coverage   90.42%   90.39%   -0.03%     
==========================================
  Files         790      791       +1     
  Lines      275421   275995     +574     
  Branches    52830    52973     +143     
==========================================
+ Hits       249052   249494     +442     
- Misses      16776    16912     +136     
+ Partials     9593     9589       -4     
Files with missing lines Coverage Δ
lib/internal/bench_runner/harness.js 98.95% <100.00%> (+<0.01%) ⬆️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants