Conversation
Remove two inline headers deleted by the V8 15.2 update from the postmortem-metadata inputs. Their remaining references prevent Ninja from building the target. Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
inoway46
marked this pull request as ready for review
October 5, 2026 13:46
aduh95
added
dont-land-on-v22.x
Contributor
Author
|
The full Ninja build completed successfully locally on macOS x64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove two deleted inline headers from the
postmortem-metadatainputs. These stale references cause Ninja builds to fail after the V8 15.2 update:Verified that the Ninja dry-run and the
postmortem-metadatatarget complete after the change.Refs: #65161