Conversation
nodejs-github-bot
added
fs
The JavaScript implementation of `fs.realpath()` and `fs.realpathSync()` joined a symlink target with the rest of the path through `path.resolve()`, which collapses `..` lexically before the preceding components have been resolved. A link such as `d -> c/../d`, where `c` is itself a symlink, was therefore rewritten back to `d` and the walk never terminated. Keep `.` and `..` in the path while walking it, and apply `..` to the already resolved parent, matching `realpath(3)` and `fs.realpathSync.native()`. Only normalize the final result, and skip caching link targets containing `..`, whose resolution depends on the path walked before them. Fixes: nodejs#60295 Signed-off-by: jazelly <xzha4350@gmail.com>
jazelly
marked this pull request as ready for review
October 4, 2026 21:06
Member
Author
|
cc @nodejs/fs |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65457 +/- ##
==========================================
+ Coverage 90.13% 90.43% +0.30%
==========================================
Files 751 790 +39
Lines 253635 275506 +21871
Branches 47786 52852 +5066
==========================================
+ Hits 228615 249162 +20547
- Misses 16268 16742 +474
- Partials 8752 9602 +850
🚀 New features to boost your workflow:
|
jazelly
added
the
request-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.realpath()andfs.realpathSync()resolved symlink targets withpath.resolve(), which collapses
..before the preceding symlink isresolved. A link like
d -> c/../dwas turned back intod, causingan infinite loop.
Fixed this by resolving
..against the already resolved parent instead.This matches how native implements realpath:
..is applied to the already-resolved prefix, and symlink targets arespliced into the remaining path without lexical normalization.
Fixes: #60295
Signed-off-by: jazelly xzha4350@gmail.com