Repository navigation
test_runner: do not read from process.argv and process.cwd() in run() - #63444
Closed
MD-Mushfiqur123 wants to merge 1 commit into
Closed
MD-Mushfiqur123 wants to merge 1 commit into
MD-Mushfiqur123 wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: god032396-del <god032396@gmail.com>
MD-Mushfiqur123
force-pushed
the
fix/run-no-process-globals
branch
from
June 13, 2026 02:25
dd377c8 to
c8b7b78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move \process.argv\ and \process.cwd()\ reads out of
un()\ and into \main/test_runner.js, passing them as options instead.
Why
Closes #53867. The
un()\ function is also exposed to end users via the
ode:test\ API, so it should not depend on \process\ globals. All process-level state should be captured at the CLI entry point (\main/test_runner.js) and passed down.
How
\lib/internal/main/test_runner.js:
\lib/internal/test_runner/runner.js:
The \cwd = process.cwd()\ default in
un()\ is preserved for backward compatibility when called programmatically without options.
Testing
unner.js\ was reading directly