Skip to content

Uninitialized DH computeSecret should throw instead of returning empty buffers #63674

Closed
#63922
Closed
Uninitialized DH computeSecret should throw instead of returning empty buffers#63674
#63922
Labels
cryptoIssues and PRs related to the crypto subsystem.

Description

@ChALkeR
ChALkeR
opened on May 31, 2026

When a DH instance does not have a private key initialized, it just happily returns empty buffers for all public keys.

That is a footgun and needs to be fixed (turned into a throw).

Welcome to Node.js v26.2.0.
Type ".help" for more information.
> require('crypto').createDiffieHellman(512).computeSecret(Buffer.alloc(64,1))
<Buffer >

See also #62838

Activity

  1. ChALkeR
    added
    cryptoIssues and PRs related to the crypto subsystem.
    on May 31, 2026

  2. Anshikakalpana commented on May 31, 2026

    @Anshikakalpana
    Anshikakalpana
    on May 31, 2026
    Contributor

    @ChALkeR I worked on the same pattern in #62838 and #63162. Happy to take this — will follow the same runtime deprecation approach

  3. ChALkeR commented on May 31, 2026

    @ChALkeR
    ChALkeR
    on May 31, 2026
    MemberAuthor

    I think this one can go straight to error instead of deprecation
    @panva thoughs?

  4. panva
    added a commit that references this issue on Jun 15, 2026

    crypto: throw on uninitialized DH computeSecret

    70f82de
  5. nodejs-github-bot
    closed this as completedin #63922on Jun 17, 2026
  6. nodejs-github-bot
    added a commit that references this issue on Jun 17, 2026

    crypto: throw on uninitialized DH computeSecret

    63907e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cryptoIssues and PRs related to the crypto subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions