Repository navigation
fix(harness): files-only ctx.glob and an incomplete-run summary - #484
Merged
Merged
Conversation
Node's fs.globSync also returns matching directories, and vitest names its image snapshot directories <name>.test.tsx, so a rule that globbed then read threw EISDIR. The files-only guarantee now lives in portableFileGlob, shared by the published ctx and the in-repo one, and is stated on IMetaCtx.glob. Closes #476
A rule that throws checked nothing, yet the summary still read "lint-meta: no violations". Both CLIs now end such a run with an INCOMPLETE line naming how many rules threw, and the in-repo CLI reds the build on any throw, not only for ciCritical rules. Closes #478
Shironex
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two harness fixes, one commit each.
ctx.globreturns files only. Node'sfs.globSyncalso returns matching directories, and vitest names its image snapshot directories<name>.test.tsx, so a rule that globbed then read threwEISDIR. The guarantee now lives in oneportableFileGlobshared by the published ctx and the in-repo one, and is documented onIMetaCtx.glob.lint-meta: INCOMPLETE, N of M rules threw and checked nothing, and the in-repo CLI now fails the build on any throwing rule, not onlyciCriticalones (the published CLI already did).Closes #476
Closes #478
Test plan
bun test packages/harness tools/lint-meta(207 pass),bun run test:nodebun run lint,bun run buildReplaces #482, which GitHub closed when its base branch was deleted on merging #481.