Skip to content

refactor(engine): remove the Council feature - #483

Merged
Shironex merged 5 commits into
mainfrom
refactor/remove-council
Oct 1, 2026
Merged

Shironex merged 5 commits into
mainfrom
refactor/remove-council

Conversation

@Shironex

@Shironex Shironex commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Stacked on the harness fixes PR. Removes Council (the multi-agent debate board) from every tier: Nightcore is moving to maintenance mode and this feature is no longer carried. 159 files, about 19k lines deleted, five commits ordered top-down.

  • web: the council view, nav entry and bridge wrappers
  • core: five Tauri commands, the in-memory run registry, council_worktree.rs, and the debate event routing
  • engine: the whole debate/ module and the seat marker in session start
  • contracts: debate events, council commands and presets, the nc:debate channel; Rust contracts regenerated
  • docs site: the Council reference page and links to it

Wire changes beyond the named Council members

  • resolve-worktree-op (command) and worktree-op-required (event) are removed. Only the Council build driver used them.
  • The optional council field leaves start-session, session-started and session-failed. It was never serialized for board sessions, so their wire output is unchanged.
  • Fixture counts pinned in contracts/mod.rs drop accordingly (SurfaceCommand 23 to 17, NightcoreEvent 47 to 45).

No Council state was ever persisted, so existing installs load unchanged. No lint-meta baseline, coverage floor or lockfile changed. The two research docs under docs/research stay as history.

Closes #387

Test plan

  • bun run build, bun run lint, web build, docs build (22 pages)
  • bun run codegen:check
  • bun run test:node (1833 pass), test:plugin, test:web (2876 pass)
  • bun run check:rust (1574 tests)
  • Coverage gates: node 94.73% lines, rust 74.13% lines, web thresholds met
  • git grep -i council and debate over apps, packages, tools: no hits
  • Launch the desktop app and confirm the nav and board are unaffected

@Shironex Shironex added documentation Improvements or additions to documentation refactor Code restructuring with no behavior change security Sandbox, confinement, injection defense, permissions area: web React board (apps/web) area: core Rust/Tauri backend (apps/desktop/src-tauri) area: engine Bun sidecar / Claude SDK sessions area: contracts Zod schemas + two-way codegen (zod->Rust, ts-rs->TS) labels Oct 1, 2026
@Shironex
Shironex force-pushed the refactor/remove-council branch from 591ac87 to c28169d Compare October 1, 2026 21:20
@Shironex
Shironex force-pushed the fix/lint-meta-reporting branch from 59a60ed to 412df6f Compare October 1, 2026 21:20
@Shironex
Shironex changed the base branch from fix/lint-meta-reporting to main October 1, 2026 21:20
Drops the debate events, the council commands and presets, the nc:debate
channel, and the resolve-worktree-op / worktree-op-required pair that only the
council build driver used. The optional council seat marker leaves
start-session, session-started and session-failed; it was never serialized for
board sessions, so their wire output is unchanged. Rust contracts regenerated.
@Shironex
Shironex force-pushed the refactor/remove-council branch from c28169d to 0cfb453 Compare October 1, 2026 21:27
@Shironex
Shironex merged commit 0d38661 into main Oct 1, 2026
12 checks passed
@Shironex
Shironex deleted the refactor/remove-council branch October 1, 2026 21:33
@github-project-automation github-project-automation Bot moved this from Todo to Done in Nightcore Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: contracts Zod schemas + two-way codegen (zod->Rust, ts-rs->TS) area: core Rust/Tauri backend (apps/desktop/src-tauri) area: engine Bun sidecar / Claude SDK sessions area: web React board (apps/web) documentation Improvements or additions to documentation refactor Code restructuring with no behavior change security Sandbox, confinement, injection defense, permissions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Council #383 hardening — defense-in-depth follow-ups from the write-capable driver review

1 participant