Repository navigation
Version Packages - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@noctcore/eslint-plugin-code-quality@0.4.2
Patch Changes
#64
aa1ae71Thanks @Shironex! -skipped-tests-need-trackingno longer reports the text of a skip that is not a call.Reports less. The rule found
it.skip(,test.fixme(,xit(,xdescribe(andxtest(by scanning each source line, so the same text inside a string, a template literal or a comment was reported as a skipped test. It now reads the skip from the call itself. A test file that lints probe code held as a string (a config wiring test with seeded violations, aRuleTestersuite for a wrapper rule) can spell a skipped test in its own source, and a comment can mentionit.skip(in prose.Every real skip that was reported before is still reported: the
.skip/.fixmemodifier onit,testordescribe(also reached through a member,test.describe.skip(), and thexit/xdescribe/xtestaliases. The tracking marker is still looked up in the source text of the lookback window, so a marker in a comment counts as before.The report now sits on the callee (
it.skip,xit) or on thenode:testoption, where it used to cover the whole line from column 1. The line is unchanged, so aneslint-disable-next-linekeeps working.