feat(media): add media volume osd with media player name - #3835
feat(media): add media volume osd with media player name#3835AdityaKr015 wants to merge 5 commits into
Conversation
[P2] Preserve the debounce window for trailing property refreshes — src/dbus/mpris/mpris_service.cpp:1658-1667DeferredCall::callLater() runs at the next main-loop iteration, not after the remaining 120 ms debounce interval. The Consequently, a player emitting PropertiesChanged every 16 ms can still trigger a two-interface GetAll refresh on every loop iteration; the existing debounce is effectively bypassed. Schedule one trailing refresh for the end of [P2] Reset the volume baseline when the active player changes — src/shell/osd/media_osd.cpp:55-56m_lastVolumeis global to MediaOsd and is compared without checking activePlayer.busName. Active-player selection |
Summary
This PR shows OSD when media volume is changed with
playerctl, with MPRIS supported Media Player Name withdisc-filledicon.Motivation
For the people who wants OSD when changing media volume.
Type of Change
Related Issue
Closes #3791
Testing
just format,`meson compile -C build-debug no issue.meson test -C build-debugall 72 tests passed.just lintall clear no errors.pkill noctaliathen started new feature one./build-debug/noctaliaplayerctlcmd using VLC, Celluloid, Dragon Player, ElisaManual Coverage
Screenshots / Videos
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installedassets/translations/en.json, or this PR adds no new user-facing strings.