-
Notifications
You must be signed in to change notification settings - Fork 8
[feat]: SPR Timeseries #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JZahner1
wants to merge
10
commits into
nmfs-ost:spr
Choose a base branch
from
JZahner1:spr
base: spr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
225345f
feat: plot of SPR timeseries
JZahner1 6c3d0d7
feat: Custom y-axis labels for plot_spr
JZahner1 e54debe
test: tests for plot_spr
JZahner1 acddf37
refactor: simplified spr vs 1-spr calculation
JZahner1 671ed48
feat: added correct key quantities for correct caption/alt text forma…
JZahner1 36821c3
Remove unit_label
JZahner1 911c42e
refactor: rename to plot_spawning_potential_ratio
JZahner1 251f402
fix: account for user specifying multiple SPR quantities
JZahner1 4546ff4
Merge branch 'spr' of https://github.com/JZahner1/stockplotr into spr
JZahner1 42e7814
fix: remove scale_amount from .rda file creation
JZahner1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JZahner1 marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| test_that("plot_spawning_potential_ratio generates plots without errors", { | ||
| # expect error-free plot with minimal arguments | ||
| expect_no_error( | ||
| plot_spawning_potential_ratio(stockplotr::example_data, quantity="spr"), | ||
| ) | ||
|
|
||
| expect_no_error( | ||
| plot_spawning_potential_ratio(stockplotr::example_data, quantity="fishing_intensity") | ||
| ) | ||
|
|
||
| expect_no_error( | ||
| plot_spawning_potential_ratio(stockplotr::example_data, quantity="spr_ratio") | ||
| ) | ||
|
|
||
|
|
||
| # expect error-free plot with many arguments | ||
| expect_no_error( | ||
| plot_spawning_potential_ratio( | ||
| stockplotr::example_data, | ||
| quantity = "spr_ratio", | ||
| ref_line = "biomass_target" | ||
| ) | ||
| ) | ||
|
|
||
|
|
||
| # expect ggplot object is returned | ||
| expect_s3_class( | ||
| plot_spawning_potential_ratio( | ||
| stockplotr::example_data, | ||
| ref_line = c("target" = 0.80) | ||
| ), | ||
| "gg" | ||
| ) | ||
| }) | ||
|
|
||
| test_that("rda file made when indicated", { | ||
|
JZahner1 marked this conversation as resolved.
|
||
| # export rda | ||
| plot_spawning_potential_ratio( | ||
| stockplotr::example_data, | ||
| ref_line = "msy", | ||
| module = "DERIVED_QUANTITIES", | ||
| make_rda = TRUE, | ||
| figures_dir = getwd() | ||
| ) | ||
|
|
||
| # expect that both figures dir and the spawning_biomass_figure.rda file exist | ||
| expect_true(dir.exists(fs::path(getwd(), "figures"))) | ||
| expect_true(file.exists(fs::path(getwd(), "figures", "spr_figure.rda"))) | ||
|
|
||
| # erase temporary testing files | ||
| file.remove(fs::path(getwd(), "captions_alt_text.csv")) | ||
| file.remove(fs::path(getwd(), "key_quantities.csv")) | ||
| unlink(fs::path(getwd(), "figures"), recursive = T) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.