Skip to content

Update CAAL text with clearer explanation of methods - #340

Merged
Rick-Methot-NOAA merged 6 commits into
mainfrom
caal-fixes
Oct 1, 2026
Merged

Update CAAL text with clearer explanation of methods#340
Rick-Methot-NOAA merged 6 commits into
mainfrom
caal-fixes

Conversation

@e-perl-NOAA

@e-perl-NOAA e-perl-NOAA commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Resolves #339 by @GrantAdams.

@e-perl-NOAA e-perl-NOAA added documentation Improvements or additions to documentation Manual labels Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Here are the artifacts from your PR:
textidote_report
SS330_User_Manual.pdf
Please review your changes in the linked artifacts.

@e-perl-NOAA

e-perl-NOAA commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

@Rick-Methot-NOAA I fixed the handful of typos, please let me know if you see anything else that needs to be updated or fixed.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

@Rick-Methot-NOAA

Rick-Methot-NOAA commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

Looks good, but now I see that the Lbin_lo Lbin_hi section should be merged with the CAAL section because Lbin_lo and lbin_hi are only used for CAAL.
@iantaylor-NOAA

@iantaylor-NOAA

iantaylor-NOAA commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

@Rick-Methot-NOAA, I shifted most of the description of the Lbin_lo and Lbin_hi to the CAAL section, along with a little bit of wordsmithing in that section. Feel free to request or add further changes if this doesn't look good to you.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Here are the artifacts from your PR:
textidote_report
SS330_User_Manual.pdf
Please review your changes in the linked artifacts.

@Rick-Methot-NOAA

Rick-Methot-NOAA commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

How about merging CAAL completely into the Lbin section.
Header: Lbin_lo and Lbin_hi for Conditional age-at-length
Lbin_lo and Lbin_hi are used to specify whether an age composition observation is a marginal composition covering the entire length range, or an observation that is conditional on the length range specified by lbin_lo and lbin_hi. ......

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Here are the artifacts from your PR:
textidote_report
SS330_User_Manual.pdf
Please review your changes in the linked artifacts.

Rick-Methot-NOAA
Rick-Methot-NOAA approved these changes Oct 1, 2026
View reviewed changes

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Rick-Methot-NOAA
Rick-Methot-NOAA approved these changes Oct 1, 2026
View reviewed changes

@Rick-Methot-NOAA Rick-Methot-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing. add: CAAL somewhere so people can search for that

@iantaylor-NOAA

iantaylor-NOAA commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

One more thing. add: CAAL somewhere so people can search for that

Good idea. Go ahead and merge if the addition of the "CAAL" looks OK.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

@Rick-Methot-NOAA
Rick-Methot-NOAA merged commit 246223c into main Oct 1, 2026
6 checks passed
@Rick-Methot-NOAA
Rick-Methot-NOAA deleted the caal-fixes branch October 1, 2026 23:18
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

Here are the artifacts from your PR:
SS330_User_Manual.pdf
textidote_report
Please review your changes in the linked artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rick-Methot-NOAA Rick-Methot-NOAA Rick-Methot-NOAA approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation Manual

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CAAL example in §7.17 does not say which bin method it assumes, and the manual never states that Lbin_lo/Lbin_hi must be integers under methods 1 and 2

3 participants

@e-perl-NOAA @Rick-Methot-NOAA @iantaylor-NOAA