Skip to content

[feat] Add functionality to rename legacy figure/table docs - #585

Merged
sbreitbart-NOAA merged 2 commits into
feat-update-reportfrom
fix-legacy-renaming
Oct 2, 2026
Merged

sbreitbart-NOAA merged 2 commits into
feat-update-reportfrom
fix-legacy-renaming

Conversation

@sbreitbart-NOAA

Copy link
Copy Markdown
Collaborator

What is the feature?

  • Add functionality to rename legacy figure/table docs with rerender_skeleton()
  • fix bug where tables docs weren't renamed in create_template()

How have you implemented the solution?

  • in rerender_skeleton(): IDs other files in the skeleton's folder and evaluates if Figures appears before Tables, and if not, reorders the files by changing the filenames
  • create_template(): copying behavior for updating figures doc filenames if not SAR

Does the PR impact any other area of the project, maybe another repo?

  • No

…eleton(); fix bug where tables docs weren't renamed in create_template()
Comment thread R/create_template.R

@Schiano-NOAA Schiano-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my one comment, it works and LGTM!

@sbreitbart-NOAA
sbreitbart-NOAA merged commit 5a78e18 into feat-update-report Oct 2, 2026
1 check passed
@sbreitbart-NOAA
sbreitbart-NOAA deleted the fix-legacy-renaming branch October 2, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants