feat: persist data in preview and editor on astro page - #529
Open
hilhorstt wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
hilhorstt
marked this pull request as ready for review
July 14, 2026 07:38
hilhorstt
enabled auto-merge (squash)
July 14, 2026 08:11
wouter-ictu
reviewed
Jul 14, 2026
| content edited on the home page (persisted to localStorage) so the | ||
| preview reflects the user's own document. | ||
| --> | ||
| <script is:inline define:vars={{ storageKey: EDITOR_STORAGE_KEY }}> |
Contributor
There was a problem hiding this comment.
Can we add this script to the editorPersistence util as well? So all demo code is in the same file?
wouter-ictu
reviewed
Jul 14, 2026
| */ | ||
| async function getEditor(el: EditorHost): Promise<EditorLike | undefined> { | ||
| await customElements.whenDefined('clippy-editor'); | ||
| for (let i = 0; i < 300 && !el.editor; i += 1) { |
Contributor
There was a problem hiding this comment.
Is there not a ready() or equivalent available from within the editor?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.