Repository navigation
fix(queue): recover source callbacks and asynchronous queue advance - #82
Merged
Merged
Conversation
Signed-off-by: IanHollow <72767437+IanHollow@users.noreply.github.com>
Signed-off-by: IanHollow <72767437+IanHollow@users.noreply.github.com>
Signed-off-by: IanHollow <72767437+IanHollow@users.noreply.github.com>
Signed-off-by: IanHollow <72767437+IanHollow@users.noreply.github.com>
Signed-off-by: IanHollow <72767437+IanHollow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Token-created package source validations had no explicit completion callback, and a successful queue callback could finish before GitHub exposed the next candidate. Verified start/completion notifications now invalidate stale source evidence and restore admission only from current actual jobs. A bounded post-publication pass dispatches the next verified front candidate without waiting for the hourly recovery schedule.
Evidence
Merge Danger
Door: two-way. Restore the previous shared release pin and remove optional source notification inputs to roll back.
Blast Radius: automation. Queue/status operations change; existing job gates, token permissions, source ownership checks, release builders and signing trust remain intact.
Hosted validation on
128a7e6fed565147424c30227f4d72bd4406d00fpassed the actual Nix validation job: all 161 tests (including hermetic callback Bash execution), strict documentation build, workflow/security checks and real Nix attribute discovery. Full current-head checks and normal merge-group validation remain required before release.Protected queue commit
ab8e486d3d1c48edd116578e097a46eb0c8f5097passed CI, partitioning fuzz and sign-off, then merged normally. v2.12.0 was published by the independently pinned SLSA builder. The signed tag, archive checksum, manifest source identity and all three provenance subjects were independently verified. Archive SHA-256:ec1e9099b62fc4f6738ccebef0803e417fd97aba7e078385a3535705590ba9e4.