Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tool arguments were never attached to ExecutionContext, so middleware and
interceptors could not inspect the actual input (context.input was always
undefined). This contradicts the SDK reference and Interceptor guide, both
of which show context.input as the canonical way to read tool arguments
in cross-cutting logic.
Changes Made
inputfield to theExecutionContextinterface (types.ts)context.inputwith the sanitised tool arguments at both callsites in server.ts (synchronous path and runTaskAsync)
_metais excluded from input as it already lives in context.metadataType of Change
Related Issues
Closes #328
Testing
and _meta is correctly excluded