Skip to content

Add part filter by manufacturer, supplier and product group - #6

Merged
nilres merged 1 commit into
masterfrom
feature/part-filter
Oct 21, 2026
Merged

nilres merged 1 commit into
masterfrom
feature/part-filter

Conversation

@nilres

@nilres nilres commented Oct 21, 2026

Copy link
Copy Markdown
Owner

What

Part trees could only be narrowed by free text and were always grouped by product group. They can now be filtered by further criteria and grouped differently.

  • PartFilter (openecraft-parts, new filter module): text, manufacturer, supplier, top group and product group criteria, plus the tree grouping (Grouping: product group / manufacturer / supplier). distinct_values collects the dropdown values. Unit tests in filter/tests.rs.
  • part_filter widget (openecraft-ui): text field with a ✖ reset button, a collapsible "Filter criteria" grid with dropdowns, and an "N of M parts" count. The product group list follows the selected top group.
  • part_tree now takes a &PartFilter instead of a &str. In manufacturer/supplier grouping the parts are sorted into product groups below each entry.
  • Used in all three trees: parts management, the part selection dialog (its own filter row was replaced) and the standalone parts manager.
  • New texts in all four languages in extra.tsv; (no product group) is now translated too.

Notes for reviewers

  • Top group names ("Electrical engineering", …) were already shown untranslated and still are in the new dropdown – a separate fix.
  • cargo test --workspace and both clippy runs (native and wasm32) pass without warnings; the UI was not checked in the running app.

🤖 Generated with Claude Code

- PartFilter in openecraft-parts: text, manufacturer, supplier, top group
  and product group criteria plus tree grouping, with unit tests
- Shared part_filter widget in openecraft-ui; part_tree groups by product
  group, manufacturer or supplier
- Use the filter in parts management, part selection and the parts manager
- Translate the new texts and "(no product group)"

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nilres
nilres merged commit 35348df into master Oct 21, 2026
7 of 8 checks passed
@nilres
nilres deleted the feature/part-filter branch October 25, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant