Repository navigation
Add part filter by manufacturer, supplier and product group - #6
Merged
Merged
Conversation
- PartFilter in openecraft-parts: text, manufacturer, supplier, top group and product group criteria plus tree grouping, with unit tests - Shared part_filter widget in openecraft-ui; part_tree groups by product group, manufacturer or supplier - Use the filter in parts management, part selection and the parts manager - Translate the new texts and "(no product group)" Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part trees could only be narrowed by free text and were always grouped by product group. They can now be filtered by further criteria and grouped differently.
PartFilter(openecraft-parts, newfiltermodule): text, manufacturer, supplier, top group and product group criteria, plus the tree grouping (Grouping: product group / manufacturer / supplier).distinct_valuescollects the dropdown values. Unit tests infilter/tests.rs.part_filterwidget (openecraft-ui): text field with a ✖ reset button, a collapsible "Filter criteria" grid with dropdowns, and an "N of M parts" count. The product group list follows the selected top group.part_treenow takes a&PartFilterinstead of a&str. In manufacturer/supplier grouping the parts are sorted into product groups below each entry.extra.tsv;(no product group)is now translated too.Notes for reviewers
cargo test --workspaceand both clippy runs (native and wasm32) pass without warnings; the UI was not checked in the running app.🤖 Generated with Claude Code