Repository navigation
Follow the desktop theme on Linux; add AppImage update information - #205
Merged
Merged
Conversation
The AppImage catalog review found the editor dark on a light desktop and the AppImage without update information. - openecraft-ui `theme`: light fallback for the theme "System"; on Linux, where winit reports no theme, the colour scheme of the settings portal (or a dark GTK_THEME) chooses and changes are followed while running - Editor and parts manager use it at start - build.sh embeds gh-releases-zsync update information and writes the .zsync file next to the AppImage (APPIMAGE_UPDATE_INFO overrides) - CI installs zsync and uploads the .zsync with the Linux packages - Changelog, installation and release docs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the two suggestions of the AppImage catalog test in AppImage/appimage.github.io#11522.
Light theme unless the desktop is dark
With the theme System, egui uses
fallback_themewhen the window system reports no theme, and that defaults to dark. winit 0.30 reports none on Linux (X11 alwaysNone, Wayland only its own overrides), so the editor and the parts manager always started dark there.openecraft_ui::theme::follow_system, called at start by the editor and the parts manager:org.freedesktop.appearance color-schemefrom the settings portal (ReadOne,Readfor version 1 portals), otherwise aGTK_THEMEnamed dark, and followsSettingChangedin a thread; the start waits at most 300 ms for the first answertheme_preferenceis persisted by egui).zbus(Linux only) was already in the build through egui's AccessKit;Cargo.lockgains only the edge.AppImage update information
build.shpasses-u "gh-releases-zsync|<owner>|<repo>|latest|OpenECraft-*-<arch>.AppImage.zsync"(owner/repo fromGITHUB_REPOSITORY, defaultnilres/OpenECraft;APPIMAGE_UPDATE_INFOoverrides, empty disables), requireszsyncmakeand checks that the.zsyncwas written..zsyncinto the current folder, so it now runs intarget/installer/.zsyncin the Debian container and uploads*.AppImage.zsync; the release workflow copies the whole artifact, so the file lands in the release andSHA256SUMS.Testing
cargo test --workspace,cargo clippy --workspace --all-targetsand the wasm clippy pass (Windows).org.freedesktop.portal.Settingsservice: correct theme at start withReadOneand withRead, light/dark onSettingChanged, other keys ignored. That test caught a lost change right after start, fixed by subscribing before the first read..upd_infoand its.zsyncnext to it.Not tested: the full AppImage build (runs in CI's
linux-packagesjob) and the app on a real GNOME/KDE desktop. After the next release,/reteston the catalog PR should confirm both suggestions are resolved.🤖 Generated with Claude Code