Repository navigation
Bundle the X11 window libraries in the AppImage - #155
Merged
Merged
Conversation
The AppImage catalog test (Ubuntu 22.04) quit at start with "Library libxkbcommon-x11.so could not be loaded": winit loads its window libraries at run time and the AppImage carried none. - build.sh: copy libxkbcommon, libxkbcommon-x11, libxcb-xkb, libXcursor, libXi and their dependencies to usr/lib, point the editor and the parts manager there with patchelf, ship the packages' copyright files - build.sh: refuse a library that is neither bundled nor on every system, and bundled libraries needing a newer glibc than the programs - build.sh: ship the AppStream data as appdata.xml in the AppImage - ci.yml: install patchelf and the libraries in the Debian 12 container - installation.md, CHANGELOG.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The AppImage catalog test of
OpenECraft-0.1.1-x86_64.AppImage(AppImage/appimage.github.io#11522) fails on Ubuntu 22.04: the editor panics at start withwinit loads its window libraries with
dlopenat run time, and the AppImage carried no libraries at all, so it relied onlibxkbcommon-x11-0(andlibXcursor,libXi) being installed.What changed
installer/linux/build.sh, newbundle_libsstep ofbuild_appimage:libxkbcommon,libxkbcommon-x11,libxcb-xkb,libXcursor,libXiand their dependencies (libXrender,libXfixes,libXext) tousr/lib; libraries of the AppImage excludelist (libX11,libxcb,libwayland-client,libGL,libEGL) and the Wayland libraries tied tolibwayland-clientstay with the hostRUNPATH$ORIGIN/../libon the editor and parts manager (and$ORIGINon the libraries) withpatchelf, so noLD_LIBRARY_PATHleaks into processes the app starts (plugins, …)copyrightfiles of the bundled packages tousr/share/doc/<package>/(MIT/X11 licences)….appdata.xmlin the AppImage, the name the catalog's lint looks for (it passesappstreamcli validate-tree).github/workflows/ci.yml: installspatchelf,libxkbcommon-x11-0,libxcursor1,libxi6in the Debian 12 containerdocs/installation.md,CHANGELOG.mdTesting
build.sh appimagein WSL (Ubuntu 26.04) on the binaries of the v0.1.1 release (OPENECRAFT_BIN_DIR): the AppImage started on X11 (WSLg) and kept running;LD_DEBUG=libsshows all bundled libraries loaded from the AppImage'susr/libGLIBC_2.38>GLIBC_2.35of the programs); the Debian 12 packages CI bundles need at mostGLIBC_2.33cargo test(no Rust changes)Notes for review
dpkg-queryfor the licence files); CI already builds on Debian 12./reteston Add OpenECraft AppImage/appimage.github.io#11522.🤖 Generated with Claude Code