Also use custom http client (added in #5) for downloading files - #8
Merged
Merged
Conversation
Removes the internal `Client(IConnection)` constructor used by the deprecated constructors. They will instead use the public `Client(Options)` constructor.
nickelc
force-pushed
the
proxy-downloads
branch
from
January 26, 2026 11:27
804f313 to
0a21413
Compare
Owner
|
Thank you for catching this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in an environment where a custom http client is required to reach the internet, that downloads were not working. This fixes the download method to use the httpclient provided to the modio.net client.