Support On Cooldown Attacks - #180
Merged
Merged
Conversation
squash
; Conflicts: ; src/main/java/com/attacktimer/ClientUtils/Utils.java ; src/main/java/com/attacktimer/Damage.java ; src/main/java/com/attacktimer/VariableSpeed/State/TickCount.java ; src/main/java/com/attacktimer/VariableSpeed/VariableSpeed.java ; src/test/java/com/attacktimer/RoyalTitansTest.java ; src/test/java/com/attacktimer/TormentedDemonsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the plugin such that certain boss mechanics which trigger when a player is already on cooldown can be modelled. These new capabilities are then used for Doom and Maggot King which have various mechanics that let the player attack even when on cooldown and can overwrite the existing cool down.
These are unfortunately in
onRenderbecause we need to catch the mechanic nice and early to overwrite the cooldown. I tried with them inonGameTickand they were just inconsistent.Other changes
gamevalAPI for The special NPCs, nightmare pillars and ALL combat dummiesHUMAN_BOWbut there are some exceptions for special attacks and venny bow.enableMetronomeconfig option from the panel, it's still there because I believe these are saved to disk so it's easier to just deprecate this and stop using it rather than need a migration.Closes #159
Testing
Doom Testing: https://youtu.be/mgu-FDM7k3k
Maggot King Testing:
java_p27nngCKdS.mp4