Royal Titans - #170
Merged
Merged
Royal Titans#170
Conversation
Collaborator
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key changes:
npcSpawnedinstead of looping over every NPC in the world view to find out when to add data to their internal state.Royal Titans
The premise is simple until I noticed that the hit delay was messing things up...
As the wiki states for each elemental you kill with the correct elemental spell your next attack is speed up by 1 tick. There's this set of complications:
Therefore the code has ended up as it has. Track the elementals via the new
npcSpawned, when we attack one of them with a mage spell matching the animation data for the blast and higher work out if that attack would hit any of the other nearby elementals. Once we have this count do some hit delay maths to determine the actual speed up we expect once the projectile lands.Testing
https://youtu.be/5HSlpeKzcP0
Shows partial kills, manual casting and twinflame.
Also tested but now shown, did a Yama kill and purging staff spec was fine. Did a TD kill and the punish still worked.
Fixes #158