Use gameval in more places - #147
Merged
Merged
Conversation
Collaborator
Author
|
My greater question and why this is draft is about stripping out some of the enums we define in the plugin. It comes down to a few things:
|
Collaborator
Author
|
So my conclusion is just to keep the sets and lookups the names are now just legacy but this keeps algorithmic and relation data we want without having hard coded IDs. Of note there seems to have been some genuine drift in IDs, placeholder versus cert whatever that means. E.g. for hallowfell it has a concrete ID 34027 but then a place holder id at 34029 and a cert id at 34028. I'm electing to just trust runelite/wiki and only use the proper id. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Replaces many hard coded IDs with the
runlite.api.gamevalpackage. This is unfortunately not exhaustive, it doesn't cover:Removes projectiles from the powered staves section, this code was never used as it would've required usage of a deprecated Runelite API (#56 (comment)) which we want to stay away from. So its time to just remove it.
Adds copyright and license headers to some files which were missing them.
Testing
Did a Yama kill and didn't notice any problems.