Skip to content

Use gameval in more places - #147

Merged
Lexer747 merged 9 commits into
ngraves95:mainfrom
Lexer747:gamval
Aug 7, 2026
Merged

Lexer747 merged 9 commits into
ngraves95:mainfrom
Lexer747:gamval

Conversation

@Lexer747

@Lexer747 Lexer747 commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Replaces many hard coded IDs with the runlite.api.gameval package. This is unfortunately not exhaustive, it doesn't cover:

  • region IDs
  • graphic object ids, (yama fireballs)

Removes projectiles from the powered staves section, this code was never used as it would've required usage of a deprecated Runelite API (#56 (comment)) which we want to stay away from. So its time to just remove it.


Adds copyright and license headers to some files which were missing them.

Testing

Did a Yama kill and didn't notice any problems.

@Lexer747

Copy link
Copy Markdown
Collaborator Author

My greater question and why this is draft is about stripping out some of the enums we define in the plugin. It comes down to a few things:

  1. Naming discrepancies
  2. Set/Hashmap O(1) lookups
  3. Relational data we store along side that gameval does not have

@Lexer747

Lexer747 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

So my conclusion is just to keep the sets and lookups the names are now just legacy but this keeps algorithmic and relation data we want without having hard coded IDs.

Of note there seems to have been some genuine drift in IDs, placeholder versus cert whatever that means. E.g. for hallowfell
firefox_OSjo9pHktZ

it has a concrete ID 34027 but then a place holder id at 34029 and a cert id at 34028. I'm electing to just trust runelite/wiki and only use the proper id.

@Lexer747
Lexer747 marked this pull request as ready for review August 7, 2026 19:50
@Lexer747
Lexer747 merged commit 9b39763 into ngraves95:main Aug 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant