Repository navigation
Fixes related to polishing for release - #92
Merged
Merged
Conversation
…istics and coverage calculation
…update metadata schema
Update and restructure docs for v1.0 release
Co-authored-by: Sofia Ochkalova <61541445+ochkalova@users.noreply.github.com>
Co-authored-by: Sofia Ochkalova <61541445+ochkalova@users.noreply.github.com>
Co-authored-by: Sofia Ochkalova <61541445+ochkalova@users.noreply.github.com>
Change schema meta
Co-authored-by: Sofia Ochkalova <61541445+ochkalova@users.noreply.github.com>
Many different changes after review. Round 2
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 4.0.3. For more documentation on how to update your pipeline, please see the Synchronisation documentation. |
|
Fix/unify schema and docs
Important! Template update for nf-core/tools v4.0.3
KateSakharova
marked this pull request as ready for review
July 30, 2026 13:49
jfy133
approved these changes
Jul 30, 2026
|
|
||
| Some processes in this pipeline are resource intensive — in particular coverage calculation (CoverM), quality assessment (CheckM2), and taxonomic classification of MAGs/bins (BAT). For real-world data, these steps should be run on an HPC cluster or another compute environment with sufficient CPU, memory, and job scheduling capacity, rather than on a single local machine. | ||
|
|
||
| Depending on the resources available on your machine or cluster, you will likely need to adapt the Nextflow configuration to limit the maximum number of concurrently running jobs and other resource settings (e.g. `max_cpus`, `max_memory`, `max_time`, or `executor.queueSize` in a custom config), so that the pipeline does not try to claim more resources than are actually available. See the [nf-core configuration documentation](https://nf-co.re/docs/usage/getting_started/configuration) for guidance on writing a custom config for your infrastructure. |
Member
There was a problem hiding this comment.
These max_ values do not exist, instead you need to use the nextflow native resourcesLimits directive
| "description": "Flag to control the type of assembly study (third party assembly or not)", | ||
| "default": false, | ||
| "help": "Use this flag if the study is a third party assembly (TPA). Default: false" | ||
| "description": "Mark the assemblies as a Third PArty (TPA)", |
Member
There was a problem hiding this comment.
I thought TPA stood for 'third party annotation'
Contributor
Author
There was a problem hiding this comment.
We took it from ENA https://www.ebi.ac.uk/ena/browser/about/policies (I also thought A is for assembly)
Merged
Updated resource settings reference for Nextflow configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically that PR reflects all comments that James left in #72