Skip to content

Fixes related to polishing for release - #92

Merged
KateSakharova merged 55 commits into
devfrom
1.0.0
Jul 30, 2026
Merged

KateSakharova merged 55 commits into
devfrom
1.0.0

Conversation

@KateSakharova

@KateSakharova KateSakharova commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Basically that PR reflects all comments that James left in #72

ochkalova and others added 30 commits July 8, 2026 14:05
Update and restructure docs for v1.0 release
@github-actions

github-actions Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 4.0.3.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the Synchronisation documentation.

@KateSakharova KateSakharova changed the title 1.0.0 Fixes related to polishing for release Jul 27, 2026
@github-actions

github-actions Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 670bdc6

+| ✅ 251 tests passed       |+
#| ❔   9 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: .github/workflows/linting_comment.yml
  • nextflow_config - Config variable ignored: params.input
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-seqsubmit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_dark.png
  • container_configs - container_configs

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.3
  • Run at 2026-07-30 14:30:25

@KateSakharova
KateSakharova marked this pull request as ready for review July 30, 2026 13:49
@KateSakharova
KateSakharova requested a review from jfy133 July 30, 2026 13:59
Comment thread docs/usage.md Outdated

Some processes in this pipeline are resource intensive — in particular coverage calculation (CoverM), quality assessment (CheckM2), and taxonomic classification of MAGs/bins (BAT). For real-world data, these steps should be run on an HPC cluster or another compute environment with sufficient CPU, memory, and job scheduling capacity, rather than on a single local machine.

Depending on the resources available on your machine or cluster, you will likely need to adapt the Nextflow configuration to limit the maximum number of concurrently running jobs and other resource settings (e.g. `max_cpus`, `max_memory`, `max_time`, or `executor.queueSize` in a custom config), so that the pipeline does not try to claim more resources than are actually available. See the [nf-core configuration documentation](https://nf-co.re/docs/usage/getting_started/configuration) for guidance on writing a custom config for your infrastructure.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These max_ values do not exist, instead you need to use the nextflow native resourcesLimits directive

Comment thread nextflow_schema.json
"description": "Flag to control the type of assembly study (third party assembly or not)",
"default": false,
"help": "Use this flag if the study is a third party assembly (TPA). Default: false"
"description": "Mark the assemblies as a Third PArty (TPA)",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought TPA stood for 'third party annotation'

@KateSakharova KateSakharova Jul 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We took it from ENA https://www.ebi.ac.uk/ena/browser/about/policies (I also thought A is for assembly)

@jfy133 jfy133 mentioned this pull request Jul 30, 2026
Updated resource settings reference for Nextflow configuration.
@KateSakharova
KateSakharova merged commit 361e07b into dev Jul 30, 2026
3 checks passed
@KateSakharova
KateSakharova deleted the 1.0.0 branch July 31, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants