Skip to content

Make most pipeline nf-tests executable with any WEBIN credentials - #116

Merged
ochkalova merged 18 commits into
devfrom
tests/any-credentials
Oct 20, 2026
Merged

ochkalova merged 18 commits into
devfrom
tests/any-credentials

Conversation

@ochkalova

@ochkalova ochkalova commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Resolves #95
Resolves #113

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/seqsubmit branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 4e39ced

+| ✅ 252 tests passed       |+
#| ❔   9 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: .github/workflows/linting_comment.yml
  • nextflow_config - Config variable ignored: params.input
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-seqsubmit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_dark.png
  • container_configs - container_configs

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 4.1.0
  • Run at 2026-10-20 14:21:13

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

❌ nf-test failed with latest Nextflow version

Note

Tests with Nextflow's latest version failed but it will not cause a CI workflow failure.
Please check if the failure is expected with newer (edge-)releases of Nextflow or if it needs fixing.

  • ❌ docker | latest-everything | Shard 7/7

See the full run for details.

@ochkalova
ochkalova force-pushed the tests/any-credentials branch from 8bdec9b to c5301db Compare October 19, 2026 13:55
@ochkalova
ochkalova force-pushed the tests/any-credentials branch from 06af0c7 to 3ffd6a5 Compare October 19, 2026 14:04
@ochkalova ochkalova changed the title Tests/any credentials Make most pipeline nf-tests executable with any WEBIN credentials Oct 19, 2026
@ochkalova
ochkalova marked this pull request as ready for review October 19, 2026 14:47

@KateSakharova KateSakharova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked with Maira about that strategy? I feel like creating SO many studies in ENA might not be the best idea. You can imagine how many times it would be done - every commit in all branches for almost all tests. I think it is VERY A LOT...
I like idea of not using pre-registered study but I also think that approach might not be the best.
I currently don't have better solution. Maybe we should turn off some tests in GA for feature branches and leave those in dev and main only? But that will require carefully running all tests locally which is pain ...

Comment thread CHANGELOG.md Resolved
Comment thread CHANGELOG.md Resolved
Comment thread CHANGELOG.md Resolved
@ochkalova

ochkalova commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor Author

@KateSakharova good point... I've asked Maira about it. It's a pity we haven't thought about it earlier. So much work done already 😢

UPD: Maira replied that it's fine until we submit to the TEST server

@KateSakharova KateSakharova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering ENA is happy with many studies - let it be!

@ochkalova
ochkalova merged commit 672c2ce into dev Oct 20, 2026
20 checks passed
@ochkalova
ochkalova deleted the tests/any-credentials branch October 20, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants