Repository navigation
Replace .out channel access with typed workflow return assignment - #157
Merged
Merged
Conversation
Access process and workflow output channels through the return value of the invocation instead of the legacy dot-out channel access, which is not supported by typed workflows. Every process and subworkflow invocation is captured in a channel variable and its named outputs are referenced on it (for example ch_faidx.fai instead of SAMTOOLS_FAIDX.out.fai), in main.nf, workflows/references.nf, prepare_genome_dnaseq and prepare_genome_rnaseq. Generated by opencode
.out channel access with typed workflow return assignment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces every legacy
.out.channel access with named access on the captured invocation result acrossmain.nf,workflows/references.nf,prepare_genome_dnaseqandprepare_genome_rnaseq.This is the next step towards full typed workflows (Phase 3 Part A, nf-core/rnaseq#1935), unblocking typed
take:/typing of nested workflows, since.outis not supported by typed workflows.Each process and subworkflow invocation is captured in a channel variable and its named outputs are referenced on it (e.g.
ch_faidx.faiinstead ofSAMTOOLS_FAIDX.out.fai).Verified:
nextflow lintandnf-core pipelines lintclean; default, htslib (x2) and hisat2 (x4) nf-tests pass with unchanged snapshots.Generated by opencode
Verified by @maxulysse