Skip to content

Merging template 4.0.3 - #453

Merged
Kevin-Brockers merged 3 commits into
nf-core:devfrom
NicoDeVeaux:merging-template-4.0.3
Aug 20, 2026
Merged

Merging template 4.0.3#453
Kevin-Brockers merged 3 commits into
nf-core:devfrom
NicoDeVeaux:merging-template-4.0.3

Conversation

@NicoDeVeaux

@NicoDeVeaux NicoDeVeaux commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Supersedes #449 — resolves the ro-crate conflict per the PR #443 pattern

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/atacseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nf-core-bot and others added 2 commits July 24, 2026 12:36
@nf-core-bot
Template update for nf-core/tools version 4.0.3
c26ac89
@NicoDeVeaux
Merge nf-core/tools 4.0.3 template update into dev
8d24a91 
Merges the nf-core-bot template branch (nf-core#449, c26ac89) following the pattern
used for 4.0.2 in nf-core#443: merge into a branch off dev and resolve there, rather
than pushing to the bot's template branch.

Only ro-crate-metadata.json conflicted. It is wholly regenerated on each build
-- none of the six UUID @ids are shared between the two sides, and each is both
a definition and a cross-reference -- so resolving it hunk-by-hunk risks
references pointing at nodes taken from the other side. Taking the template
side wholesale is also wrong: the bot generates its RO-Crate from the template
README, so its description is boilerplate carrying "TODO nf-core" placeholders
(7,179 chars against the real 13,620).

Resolved by taking dev's file and regenerating with `nf-core pipelines rocrate`.
Verified: description is the real pipeline documentation, 36 nodes, all 6 UUID
references resolve, no dangling ids.

.nf-core.yml and README.md auto-merged correctly, keeping the pipeline's lint
configuration and real documentation while taking nf_core_version 4.0.3.
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 4.0.3.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the Synchronisation documentation.

@github-actions

github-actions Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3d024f7

+| ✅ 273 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗  38 tests had warnings |!
Details

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_if_empty_null - ifEmpty(null) found in /home/runner/work/atacseq/atacseq/subworkflows/local/prepare_genome.nf: _ versions = ch_versions.ifEmpty(null) // channel: [ versions.yml ]
    _
  • local_component_structure - samplesheet_check.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - frip_score.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - igv.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - tss_extract.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - bamtools_filter.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - get_autosomes.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - plot_macs3_qc.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - plot_homer_annotatepeaks.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - gtf2bed.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - deseq2_qc.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - genome_blacklist_regions.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - multiqc_custom_peaks.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - multiqc.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - bam_remove_orphans.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - star_genomegenerate.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - macs3_consensus.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - bedtools_genomecov.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - star_align.nf in modules/local should be moved to a TOOL/SUBTOOL/main.nf structure
  • local_component_structure - align_star.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - bed_consensus_quantify_qc_bedtools_featurecounts_deseq2.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - input_check.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - bam_bedgraph_bigwig_bedtools_ucsc.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - bam_shift_reads.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - bam_filter_bamtools.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - bigwig_plot_deeptools.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - prepare_genome.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - bam_peaks_call_qc_annotate_macs3_homer.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.3
  • Run at 2026-08-20 04:17:00

Kevin-Brockers
Kevin-Brockers requested changes Aug 19, 2026
View reviewed changes

@Kevin-Brockers Kevin-Brockers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also update the changelog.

Otherwise looks good!

@NicoDeVeaux @claude
Add CHANGELOG entry for template 4.0.3
3d024f7 
Also fix the nf-core#443 entry, which linked to nf-core/chipseq instead of
nf-core/atacseq.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@NicoDeVeaux

NicoDeVeaux commented Aug 20, 2026

Copy link
Copy Markdown
Author

Please update also update the changelog.

Otherwise looks good!

done! Also noticed there was a reference to Chipseq, which I think is a mistake, in the Changelog for PR 443, so I updated that.

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

❌ nf-test failed with latest Nextflow version

Note

Tests with Nextflow's latest version failed but it will not cause a CI workflow failure.
Please check if the failure is expected with newer (edge-)releases of Nextflow or if it needs fixing.

  • ❌ docker | latest-everything | Shard 2/7

See the full run for details.

Kevin-Brockers
Kevin-Brockers approved these changes Aug 20, 2026
View reviewed changes

@Kevin-Brockers Kevin-Brockers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good🚀

@Kevin-Brockers
Kevin-Brockers merged commit 5a4c18b into nf-core:dev Aug 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kevin-Brockers Kevin-Brockers Kevin-Brockers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicoDeVeaux @Kevin-Brockers @nf-core-bot