Skip to content

fix(navigation): compact single-line items #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pimpmuckl merged 1 commit into from
Aug 20, 2026
Merged

fix(navigation): compact single-line items #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/ui/src/blocks/navigation-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ const defaultNavigationPanelSections: NavigationPanelSection[] = [
{
id: "dashboard",
label: "Dashboard",
meta: "Command center",
icon: <LayoutDashboard />,
},
{
Expand Down Expand Up @@ -800,7 +799,9 @@ function NavigationPanelNav({
data-slot="navigation-panel-item"
className={cn(
"group relative grid min-h-11 w-full items-center gap-2 rounded-lg border border-transparent text-left transition-[color,background-color] duration-[var(--nextide-motion-control)] ease-[var(--nextide-ease-out-quart)] motion-reduce:transition-none max-lg:h-11 max-lg:w-auto max-lg:min-w-max max-lg:grid-cols-[2rem_minmax(0,1fr)] max-lg:pr-3",
collapsed ? "h-11" : "h-[3.25rem]",
collapsed || (!item.meta && !item.status)
? "h-11"
: "h-[3.25rem]",
collapsed
? "mr-auto w-11 grid-cols-[2.75rem_0fr] gap-0 p-0"
: "grid-cols-[2.75rem_minmax(0,1fr)] p-0",
Expand Down
10 changes: 10 additions & 0 deletions tests/e2e/qualification.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,16 @@ test("navigation branches keep destinations and create actions distinct", async
const navigation = page.locator('[data-slot="navigation-panel-frame"]').nth(1)
const expand = navigation.getByRole("button", { name: "Expand Campaigns" })

await expect(navigation.getByRole("button", { name: "Dashboard" })).toHaveCSS(
"height",
"44px"
)
await expect(
navigation.getByRole("button", { name: "Campaigns Launch plans", exact: true })
).toHaveCSS(
"height",
"52px"
)
await expect(expand).toBeVisible()
await expect(
navigation.getByRole("button", { name: "Summer launch" })
Expand Down