Repository navigation
Conversation
The viewer is part of the server from 36: the setup installed the app anyway and then failed reading its checkout, so no end-to-end test ran against master. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
requested review from
grnd-alt,
hweihwang and
juliusknorr
as code owners
October 7, 2026 08:05
skjnldsv
force-pushed
the
feature/migrate-new-viewer-api
branch
from
October 7, 2026 08:56
cd789cf to
9addf41
Compare
5 of 6 tasks
The viewer moved into the server as @nextcloud/viewer, which takes handlers as custom elements and no longer dispatches LoadViewer or offers OCA.Viewer.registerHandler. On 36 and up, a small init script now registers a <whiteboard-viewer> element on every page, defined the first time a board opens. It renders the board as before: read-only outside the viewer (the preview of a link to the file) and side by side with another version, and an older version from its own source. Servers up to 35 keep the viewer app's LoadViewer path. The main script skips its legacy registration on 36, where it still runs as the board shares chunks with it. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
feature/migrate-new-viewer-api
branch
from
October 7, 2026 15:58
9addf41 to
492863e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Nextcloud 36 the viewer is part of the server as
@nextcloud/viewer. It takes handlers as custom elements, and nothing dispatchesLoadVieweror offersOCA.Viewer.registerHandlerany more, so whiteboards no longer open in the viewer on master.On 36, an init script now registers a
<whiteboard-viewer>element on every page. The element renders the board as before, and is defined the first time a board opens. Servers up to 35 keep the viewer app path. The first commit stops the end-to-end setup from installing the viewer app on master: it failed reading the app's checkout, so no test has run against master since the merge.The element tells it is embedded (read-only) when it sits outside the viewer modal, and that it is being compared when it sits in the comparison view. Both are found from the viewer's class names, as the old code did with
.viewer__content. On 36, Text's editor loader for tables now loads on every page, not only in Files.The listener has unit tests. I checked opening a board and an older version on a master instance. The link preview in Text and Talk needs nextcloud-libraries/nextcloud-viewer#97 and a server change first, so it is untested. Escape inside the board closes the viewer because of a
@nextcloud/vuehotkey bug.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.