Repository navigation
[stable35] fix(editor): save a JPEG with an uppercase extension as a JPEG - #3450
Merged
skjnldsv merged 2 commits intoOct 20, 2026
Merged
Conversation
Member
Author
|
/compile rebase |
nextcloud-command
force-pushed
the
fix/image-editor-uppercase-extension-stable35
branch
from
October 20, 2026 06:52
81e15f8 to
4ed5daf
Compare
Member
Author
|
/compile rebase |
nextcloud-command
force-pushed
the
fix/image-editor-uppercase-extension-stable35
branch
from
October 20, 2026 07:58
4ed5daf to
c6c543b
Compare
skjnldsv
enabled auto-merge
October 20, 2026 08:04
Member
Author
|
/compile rebase |
skjnldsv
force-pushed
the
fix/image-editor-uppercase-extension-stable35
branch
from
October 20, 2026 08:16
c6c543b to
b91c963
Compare
The image editor hands back image/JPG for ABC1234.JPG. The jpg to jpeg replacement was case sensitive, and canvas.toBlob silently falls back to PNG for a type it doesn't take, so PNG data was written into the .JPG file. Fixes #3424 Co-authored-by: Aniruddh Singh <aniruddh18122006@gmail.com> Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
fix/image-editor-uppercase-extension-stable35
branch
from
October 20, 2026 08:28
b91c963 to
5fd5fd7
Compare
skjnldsv
disabled auto-merge
October 20, 2026 08:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image editor hands back
image/JPGforABC1234.JPG. Ourjpg→jpegreplacement was case sensitive, andcanvas.toBlobsilently falls back to PNG for a type it doesn't take, so PNG data was written into the.JPGfile.Fixes #3424, taken over from #3429 by @aniruddh18122006-cyber (co-author on the commit). I left out the extension lowercasing: it renamed
ABC1234.JPGtoABC1234.jpgon save, so the original was no longer overwritten.The e2e test checks the uploaded bytes are a JPEG for
.JPGand.JPEG. Not run locally.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.