Skip to content

feat(viewer): use nextcloud-viewer instead of custom viewer (media only) - #2012

Draft
ShGKme wants to merge 1 commit into
mainfrom
feat/nextcloud-viewer
Draft

ShGKme wants to merge 1 commit into
mainfrom
feat/nextcloud-viewer

Conversation

@ShGKme

@ShGKme ShGKme commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Light theme - Custom title bar - Image -
image image
Dark theme - Custom title bar - Image -
image image
Dark theme - Native title bar - Image Overlaps title bar now (intentionally)
image image
Dark theme - Native title bar - Video -
image image

@ShGKme
ShGKme requested a review from Antreesy October 29, 2026 20:58
@ShGKme ShGKme self-assigned this Oct 29, 2026
@ShGKme
ShGKme added this pull request to stack #2013 October 29, 2026 20:58
@ShGKme ShGKme added the enhancement New feature or request label Oct 29, 2026
@ShGKme
ShGKme marked this pull request as draft October 29, 2026 20:58
@Antreesy

Copy link
Copy Markdown
Contributor

Do you want it as explicit dependency, or it's okay if it's coming with spreed PR for free?

@ShGKme

ShGKme commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Do you want it as explicit dependency, or it's okay if it's coming with spreed PR for free?

The dependency isn't needed here indeed.
But it is needed for the next one in the stack.

Base automatically changed from refactor/unneeded-div to main October 29, 2026 22:11
@ShGKme
ShGKme force-pushed the feat/nextcloud-viewer branch from 09bd295 to b0b9a6b Compare October 29, 2026 22:11
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
ShGKme force-pushed the feat/nextcloud-viewer branch from b0b9a6b to 17dbcb3 Compare October 29, 2026 22:12
@ShGKme

ShGKme commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Do you want it as explicit dependency, or it's okay if it's coming with spreed PR for free?

Moved the commit adding @nextcloud/viewer to the corresponding PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate off the OCA.Viewer global before Nextcloud 36

2 participants